Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arq integration ctx #2600

Merged
merged 2 commits into from Dec 15, 2023
Merged

Arq integration ctx #2600

merged 2 commits into from Dec 15, 2023

Conversation

ivanovart
Copy link
Contributor

Arq is broken if the integration is missing because the context is not being passed, here is my tiny fix and a test


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

@ivanovart ivanovart changed the title Fix/arq integration ctx Arq integration ctx Dec 14, 2023
@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Dec 15, 2023
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ivanovart!

@sentrivana sentrivana enabled auto-merge (squash) December 15, 2023 09:24
@sentrivana sentrivana merged commit 6470063 into getsentry:master Dec 15, 2023
124 of 126 checks passed
@ivanovart ivanovart deleted the fix/arq-integration-ctx branch December 15, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants