Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Filter out empty string releases #2591

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Dec 13, 2023

We introduced a small regression in https://github.com/getsentry/sentry-python/pull/2557/files. Instead of only allowing truthy releases, we are now allowing all non-None releases, which includes empty strings. Changing this back to the original behavior.

Unverified

The email in this signature doesn’t match the committer email.
@sentrivana sentrivana marked this pull request as ready for review December 13, 2023 11:49

Unverified

The email in this signature doesn’t match the committer email.
@sentrivana sentrivana enabled auto-merge (squash) December 13, 2023 11:59
@sentrivana sentrivana merged commit 64c42ca into master Dec 13, 2023
123 checks passed
@sentrivana sentrivana deleted the ivana/fix-empty-release branch December 13, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants