Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change code.filepath frame picking logic #2568

Merged
merged 26 commits into from Dec 12, 2023
Merged

Change code.filepath frame picking logic #2568

merged 26 commits into from Dec 12, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Dec 5, 2023 •
edited

  • search for the frame directly from the execute wrappers
  • honor in_app_include and in_app_exclude
  • fix Python 2 compatibility (co_filename is not always absolute)

@sentrivana sentrivana linked an issue Dec 5, 2023 that may be closed by this pull request
Query code.filepath points to irrelevant middleware function #2547
Closed
@sentrivana sentrivana marked this pull request as ready for review December 5, 2023 16:56
antonpirker
antonpirker reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

sentry_sdk/integrations/asyncpg.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/django/__init__.py Outdated Show resolved Hide resolved
@sentrivana sentrivana marked this pull request as draft December 11, 2023 10:42
@sentrivana sentrivana marked this pull request as ready for review December 11, 2023 17:29
antonpirker
antonpirker approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and also tested it with my sample app

@sentrivana sentrivana merged commit 7df152b into master Dec 12, 2023
123 checks passed
@sentrivana sentrivana deleted the ivana/change-frame-picking-logic branch December 12, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query code.filepath points to irrelevant middleware function
2 participants
@sentrivana @antonpirker