feat(metrics): Improve code location reporting #2552
Merged
+104
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Dec 1, 2023
decaz
reviewed
Dec 12, 2023
| ) | ||
|
|
||
| @metrics_noop | ||
| def need_code_loation( |
There was a problem hiding this comment.
I opened a PR to fix this here #2783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the reporting for context managers using
timing. It does not address the code locations for@timingwhich are currently pointing to the call site instead of the function itself. That's tricker to fix because by the time we take the measurement the stack is unwound and before the measurement the function is not yet invoked. We could work around this, but it's pretty ugly and does not really fit into how that system works at the moment.Fixes #2550