fix(integrations): Fix Lambda integration with EventBridge source #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Hey @davidcroda, thanks a ton for reporting the issue and fixing it in one go! I left a tiny suggestion, please address it and then if the tests look good (I'll have to trigger them manually) we should be good to merge.
When a lambda is triggered by an AWS EventBridge pipe the record contains an explicit "header" key with an empty list. This breaks the assumption that headers is always a dict or None. Update the AwsLambdaIntegration to explicitly verify that header is a dict before passing it on to the `continue_trace` function. Fixes getsentryGH-2545
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
davidcroda
force-pushed
the
fix-aws-lambda-integration
branch
from
cbf21ae
to
2792d17
Compare
|
Sure thing. Thanks for the quick response. |
sentrivana
approved these changes
Dec 1, 2023
|
Thanks @davidcroda! The AWS Lambda tests are failing but based on the line numbers in the tracebacks they seem to be executing the code before your changes for some reason, so that's something we have to fix -- nothing additional needed from your side. |
github-actions
bot
removed
the
Trigger: tests using secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lambda is triggered by an AWS EventBridge pipe the record contains an explicit "header" key with an empty list. This breaks the assumption that headers is always a dict or None. Update the AwsLambdaIntegration to explicitly verify that header is a dict before passing it on to the
continue_tracefunction.Fixes GH-2545