Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add source context to code locations #2539

Merged
merged 3 commits into from Nov 29, 2023

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Nov 28, 2023

The product is going to show source context with code locations on metrics. This
PR adds source context to the code location submission payload in the same
format that stack frames use.

Relay supports this with getsentry/relay#2781.

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Just one thing: this will add considerable overhead because it loads the source.
So, your call!

@jan-auer
Copy link
Member Author

jan-auer commented Nov 28, 2023

Thanks, great callout. In that case, we'll collect one more utilization metric first and then merge this.
We will collect this data through: getsentry/relay#2784

@jan-auer jan-auer enabled auto-merge (squash) November 29, 2023 10:49
auto-merge was automatically disabled November 29, 2023 10:53

Pull Request is not mergeable

@sentrivana sentrivana enabled auto-merge (squash) November 29, 2023 11:03
@sentrivana sentrivana merged commit bd68a3e into master Nov 29, 2023
468 checks passed
@sentrivana sentrivana deleted the feat/code-location-context branch November 29, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants