feat: metric span summaries #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-python into feature/span-aggregation
This was referenced Nov 23, 2023
scttcper
pushed a commit
to getsentry/sentry
that referenced
this pull request
Nov 27, 2023
This lands a callback which controls the sample rate of span local metric summaries dynamically. Refs getsentry/sentry-python#2522
sentrivana
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metric summaries to spans.
Refs this RFC: https://github.com/getsentry/rfcs/blob/main/text/0123-metrics-correlation.md
For now they are guarded behind a sample rate which is 0 by default so we can gradually judge the impact. The sampling is done globally which is not useful from a user experience point of view, but enables us to validate the behavior.