-
Notifications
You must be signed in to change notification settings - Fork 534
fix(integrations): Use wraps on fastapi request call wrapper #2476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nkaras Looks like the build is failing. I don't see any specific reason for it to be failing.. perhaps we are missing some sort of mock configuration in the tests? Linter:
I'm not sure what this Hopefully a Sentry dev can make this more clear, I probably don't know enough about the CI configuration to be of much help |
Hey @jseadragon, the AWS Lambda test failure is not related to the changes in this PR. It seems we have a general problem with PRs from contributors hitting some AWS auth issue. We'll fix that. @nkaras Thanks again for the PR! Could you please run the PR through black? The lint step is complaining about there being too many empty lines. (I'd really like to automate this at some point, but right now it needs to be done manually.) |
@sentrivana I pushed the formatting change 🤞 |
Created #2487 to track progress on the aws lambda test suite issue. |
@nkaras Looking good! Could you please merge master into this branch/rebase on master or set the PR to accept changes from maintainers (then we could do it without bothering you)? Once we're up to date with the base branch we should be good to merge. |
@sentrivana Looks like there is an open issue allowing edits from maintainers across organizations https://github.com/orgs/community/discussions/5634. It's no bother though. I just merged master. I'm more than happy to bump versions or anything else needed along the way. |
@nkaras I see, wasn't aware of that 🙈 Thanks for updating, that should be it. |
Use
_functools.wraps
on thefastapi:patch_get_request_handler
local function_sentry_call
.Add unit test to compare endpoint and call
__qualname__
.Fixes #2475