Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parse_version work in utils.py itself. #2474

Merged
merged 2 commits into from Oct 31, 2023
Merged

Make parse_version work in utils.py itself. #2474

merged 2 commits into from Oct 31, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 31, 2023 •
edited

Fixes #2473

szokeasaurusrex
szokeasaurusrex approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might be worth adding a test to ensure the same issue doesn't happen again, but we can merge without a test and add later if you think it's needed

@antonpirker
Copy link
Member Author

Thanks @szokeasaurusrex !

@antonpirker antonpirker enabled auto-merge (squash) October 31, 2023 15:50
@antonpirker antonpirker merged commit 719fcba into master Oct 31, 2023
284 checks passed
@antonpirker antonpirker deleted the antonpirker/fix-parse-version branch October 31, 2023 15:50
@antonpirker antonpirker linked an issue Oct 31, 2023 that may be closed by this pull request
Sentry-SDK 1.33 fails to import with "parse_version` is undefined with greenlet installed #2473
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry-SDK 1.33 fails to import with "parse_version` is undefined with greenlet installed
2 participants
@antonpirker @szokeasaurusrex