Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch eventlet under Sentry SDK #2464

Merged

Conversation

szokeasaurusrex
Copy link
Member

Pull request containing the same changes as #1258, created since #1258 does not allow edits from maintainers and is currently out of date with master, and therefore cannot be merged even though the PR is approved.

From @guiscaranse (original author on #1258):

This patches the eventlet library to allow it to run without issues under the Sentry SDK when using greenlet>=0.5. Eventlet doesn't pin the greenlet dependency and eventlet/eventlet#663 (that's why the sdk runs nicely under Gevent for example). So, the eventlet library itself is not a good marker to whatever the contextvars are broken or not.

This should fix #1036

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) October 25, 2023 10:08
sentry_sdk/utils.py Outdated Show resolved Hide resolved
@szokeasaurusrex szokeasaurusrex merged commit 39e3556 into master Oct 25, 2023
283 of 284 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/patch-eventlet-under-sentry-sdk branch October 25, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry with eventlet
3 participants