Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting Spans and Transactions #2358

Merged
merged 13 commits into from
Sep 11, 2023

Conversation

antonpirker
Copy link
Member

Added some docstrings and also did some minor cleanup for better readability of the code.

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so nice!

Left some typo/grammar/prettifying suggestions.

sentry_sdk/hub.py Outdated Show resolved Hide resolved
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentry_sdk/tracing_utils.py Outdated Show resolved Hide resolved
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
antonpirker and others added 8 commits September 7, 2023 17:04
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
@antonpirker antonpirker enabled auto-merge (squash) September 7, 2023 15:05
@antonpirker
Copy link
Member Author

Thanks for the fixes! Yes, at some point our lib will be a really well documented thing!

@antonpirker antonpirker merged commit 44ba734 into master Sep 11, 2023
251 of 252 checks passed
@antonpirker antonpirker deleted the antonpirker/cleanup-spans-transactions branch September 11, 2023 13:52
sentrivana added a commit that referenced this pull request Sep 18, 2023
Added some docstrings and also did some minor cleanup for better readability of the code.

---------

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants