feat(celery): Allow to override propagate_traces per task #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2023
…entry/sentry-python into feat/celery-manual-propagate-traces
|
Documentation PR: getsentry/sentry-docs#7757 |
sentrivana
approved these changes
Sep 6, 2023
|
Diff looks now ugly, but code is way more readable! 💯 |
sentrivana
pushed a commit
that referenced
this pull request
Sep 18, 2023
Adds support for a sentry-propagate-traces header on apply_async that
overrides the default behavior set through the Celery integration's
propagate_traces flag.
Example usage:
my_task.apply_async(..., headers={"sentry-propagate-traces": False})
Example use case:
We ourselves have a task that is running once every two weeks and it is sampled with ~0.01 Percent. So we can one transaction from this task a year (give or take). This task starts hundreds of child tasks. All those child tasks will inherit the sampling decision from the original task and thus will be dropped most of the times. But we want to have those child tasks transactions in our backend no matter the sampling decision of the parent.
---------
Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
sentry-propagate-tracesheader onapply_asyncthatoverrides the default behavior set through the Celery integration's
propagate_tracesflag.Example usage:
Example use case:
We ourselves have a task that is running once every two weeks and it is sampled with ~0.01 Percent. So we can one transaction from this task a year (give or take). This task starts hundreds of child tasks. All those child tasks will inherit the sampling decision from the original task and thus will be dropped most of the times. But we want to have those child tasks transactions in our backend no matter the sampling decision of the parent.
Documentation PR: getsentry/sentry-docs#7757