Fix GraphQL integration swallowing responses #2286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For capturing GraphQL responses we're
read()
ing theHTTPResponse
returned byhttp.client.HTTPConnection.getresponse
, which exhausts the payload and it can't be read again by client applications. The original workaround for this was saving the payload in aBytesIO
and aliasingHTTPResponse.read
to theBytesIO
'sread
. This works when using http.client directly, but stops working withurllib3
, which tries to determine whether there's anything left to read by checking if the response is closed, which in turn checks the internalfp
file object. By the time we'veread()
the response,fp
isNone
, and the response appears closed. This PR patchesfp
to point to theBytesIO
saved response.Fixes #2285