Adds DB connection attributes in spans #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
requested changes
Jul 28, 2023
|
I updated the code to omit data fields that we can not fill. (asked joris about what they like more) |
|
The chalice deps thing is still not fixed (something has deps to boto3 that are not working with our deps and I have not yet figured out what lib...) |
|
Also Django tests for new db attributes are still missing. |
|
Maybe I have some time in the afternoon to have another shot at this, but if not it would be great if you could take over @sentrivana . Sorry for not having everything ready.. |
No worries, I can take over. You should enjoy your vacation. :) |
Merged
sentrivana
approved these changes
Jul 28, 2023
sentrivana
deleted the
antonpirker/2270-db-connection-attributes-in-spans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2270