New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redis): Add db.system to remaining redis spans #2271

Merged

AbhiPrasad merged 1 commit into master from abhi-db-redis-data-full

Jul 25, 2023

Member

AbhiPrasad commented Jul 25, 2023

In #2038 we didn't add db.system to all the redis spans. This PR adds db.system span data to the redis spans we missed.

resolves https://www.notion.so/sentry/db-system-value-is-missing-in-Redis-spans-1c381ac16d724a58bbefd98481c93545


          feat(redis): Add db.system to remaining redis spans

998a28d

AbhiPrasad requested review from antonpirker, sentrivana and gggritso

July 25, 2023 13:50

gggritso approved these changes

View reviewed changes

Member

gggritso left a comment

👍🏻

sentrivana approved these changes

View reviewed changes

AbhiPrasad merged commit 9a0e864 into master

246 checks passed

AbhiPrasad deleted the abhi-db-redis-data-full branch

July 25, 2023 14:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment