-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(integrations): Rename request_bodies
to max_request_body_size
#2247
Conversation
Hey @mgaligniana, thanks for this PR! If we're renaming a client option the change needs to be backwards compatible so that things don't break for folks that are currently setting As for the docs, on each page if you scroll all the way to the bottom there's a Suggest an edit to this page link that takes you directly to the source. |
3e17e7f
to
8119f00
Compare
Thank you @sentrivana! I added a test similiar to the work made by Anton for other deprecated option: 888c0e1 I also created a PR on the sentry-docs repo to update the documentation: getsentry/sentry-docs#7432 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for adding a test, too. Please take a look at the comment.
Thank you @mgaligniana! 🚀 |
Hi!
This PR fixes #926
🎗️ Question: Where can I update the Sentry's documentation for this change? https://docs.sentry.io/platforms/python/configuration/options/#request-bodies