Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(loguru): add message format configuration arguments #2208

Merged
merged 9 commits into from
Jun 30, 2023
Merged

feat(loguru): add message format configuration arguments #2208

merged 9 commits into from
Jun 30, 2023

Conversation

Gwill
Copy link
Contributor

@Gwill Gwill commented Jun 28, 2023

More convenient setting message format.

@sentrivana
Copy link
Contributor

Hey @Gwill, thanks for this PR! Could you please run it through black to make this workflow green?

sentrivana
sentrivana requested changes Jun 29, 2023
View reviewed changes
sentry_sdk/integrations/loguru.py Outdated Show resolved Hide resolved
@sentrivana
Copy link
Contributor

Now mypy is complaining about this:

sentry_sdk/integrations/loguru.py:68: error: Argument "format" to "add" of "Logger" has incompatible type "str | None"; expected "str | Callable[[Record], str]"  [arg-type]
sentry_sdk/integrations/loguru.py:75: error: Argument "format" to "add" of "Logger" has incompatible type "str | None"; expected "str | Callable[[Record], str]"  [arg-type]

sentrivana
sentrivana approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gwill! Looks useful, will merge this now.

@sentrivana sentrivana enabled auto-merge (squash) June 30, 2023 12:46
@sentrivana sentrivana merged commit 0919a95 into getsentry:master Jun 30, 2023
243 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
Integration: Loguru Waiting for: Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gwill @sentrivana