Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse_url #2161

Merged
merged 7 commits into from Jun 7, 2023
Merged

Fix parse_url #2161

merged 7 commits into from Jun 7, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 7, 2023 •
edited

We're already splitting the URL while sanitizing. No need to reassemble and then disassemble it again, which also prevents #2160

Tested locally on 3.11.4

Fixes #2160

@sentrivana sentrivana marked this pull request as ready for review June 7, 2023 15:06
@antonpirker antonpirker enabled auto-merge (squash) June 7, 2023 15:33
@antonpirker antonpirker merged commit dd6bbe0 into master Jun 7, 2023
241 checks passed
@antonpirker antonpirker deleted the ivana/urlparse-fix branch June 7, 2023 15:38
@antonpirker
Copy link
Member

Fix released: https://github.com/getsentry/sentry-python/releases/tag/1.25.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.11.4 (and maybe others) break sentry-sdk's URL parsing that contains filtered elements
2 participants
@sentrivana @antonpirker