-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load AWS Lambda secrets in Github CI #2153
Conversation
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Awesome that you've fixed this. 🎖️
Left a few small comments.
…openssl problems in lambda layers.
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Make sure our AWS Lambda test setup is correct and the tests work as expected and also in a timely manner.
We run our test in AWS Lambda and then parse the log output to see what events/envelopes where sent. Because Lambda truncates this log output to 4kb, I had to change the tests to make the events/envelopes smaller in size to get the whole event/envelop in the log output.
When the AWS env vars where not set, the tests where skipped but it looked like they where successful. I made them now fail loudly in that case, so we see if they do not run.
Also made the code easier to comprehend.
Somehow related docs PR: getsentry/sentry-docs#8246
If this has been merged AND released, this PR in
sentry
can be merged: getsentry/sentry#58321