Add cache.hit and cache.item_size to Django
#2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try/sentry-python into antonpirker/2403-cache-hit-django
sl0thentr0py
requested changes
May 4, 2023
Co-authored-by: Neel Shah <neel.shah@sentry.io>
sl0thentr0py
approved these changes
May 5, 2023
nicootto
reviewed
May 9, 2023
| with hub.start_span(op=OP.CACHE, description=description) as span: | ||
| value = original_method(*args, **kwargs) | ||
|
|
||
| if value: |
There was a problem hiding this comment.
@antonpirker you can't call __bool__ of the returned value, it might not be implemented. You should check if a default value was returned, in which case it is a cache miss, or if there is not default value configured you should check value is not None.
I recently reported the same issue on ddtrace, you can check of examples on how to reproduce there DataDog/dd-trace-py#5460 and here is how they handle it DataDog/dd-trace-py#5477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django we want to add information to spans if a configured cache was hit or missed and if hit what the item_size of the object in the cache was.
Fixes #2043