Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle event being None before before_send_(transaction) #2045

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Handle event being None before before_send_(transaction) #2045

merged 2 commits into from
Apr 28, 2023

Conversation

sentrivana
Copy link
Contributor

Fixes #1979

@sentrivana sentrivana marked this pull request as ready for review April 26, 2023 10:33
@sentrivana sentrivana changed the title WIP: Handle event being None before before_send_(transaction) Handle event being None before before_send_(transaction) Apr 26, 2023
@sentrivana sentrivana force-pushed the ivana/properly-handle-beforesend-returning-none branch from e4c5b39 to 27b4da0 Compare April 27, 2023 14:35
@sentrivana sentrivana force-pushed the ivana/properly-handle-beforesend-returning-none branch from 27b4da0 to d30762f Compare April 28, 2023 07:49
@antonpirker antonpirker enabled auto-merge (squash) April 28, 2023 08:23
@antonpirker antonpirker merged commit 2c3e8b2 into master Apr 28, 2023
236 checks passed
@antonpirker antonpirker deleted the ivana/properly-handle-beforesend-returning-none branch April 28, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry SDK crashes in loop if before_send returns None or crashes
2 participants
@sentrivana @antonpirker