-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref: Add include_source_context
option in utils
#2020
Ref: Add include_source_context
option in utils
#2020
Conversation
Some users do not like the source context to be there, and so add `include_source_context` option to opt-out. Fixes getsentry#2017
c04c8fc
to
cf3cc22
Compare
…at-nawaz/add-include-source-context-option-in-utils
cf3cc22
to
6367cbf
Compare
Hey @farhat-nawaz ! Thanks for the contribution! Looks good! Now we also need the |
If you do not have time it is also possible that we merge this and take over the rest of the implementation. Should we do this? |
@antonpirker Sure, I can add those changes, no problem. |
Hey @farhat-nawaz, thanks again for contributing! Did you already have time to start on the changes that Anton proposed? If not, I'm happy to take it from here and finish it. |
Hi @farhat-nawaz, the PR looks good to me, I will merge it now as is and we'll add the missing stuff. Thank you for contributing! 🙏 |
@sentrivana Glad to have made the contribution, and looking forward to more. Sorry about not being able to respond earlier, something unexpected came up. :) |
@farhat-nawaz No problem at all, thank you for getting this kick-started! |
include_source_context
option toserialize_frame
function to allow users to opt-out of getting source context.This is my very first open-source contribution. Please let me know if I missed something.
Fixes #2017