Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added top level api to get current span and transaction #1954

Merged

Conversation

antonpirker
Copy link
Member

Idea originated in this comment of a code review: #1089 (comment)

@@ -53,6 +53,9 @@ def overload(x):
"set_user",
"set_level",
"set_measurement",
"get_current_span",
"get_current_transaction",
"get_current_span_or_transaction",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also have to add these to __init__.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed in slack, we just need get_current_span, everything else about the transaction is internal details

@antonpirker antonpirker enabled auto-merge (squash) March 15, 2023 13:41
@antonpirker antonpirker merged commit e952020 into master Mar 15, 2023
228 checks passed
@antonpirker antonpirker deleted the antonpirker/top-level-get-current-span-transaction branch March 15, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants