-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlaskIntegration JSON BadRequest with Werkzeug >= 2.1.0 #1936
Comments
Snyk has identified Werkzeug < 2.2.3 as a security vulernability. Hence this is causing a headache for me (and I'm sure others). In the meantime I've upgraded Werkzeug to 2.2.3 and monkeypatched sentry's The patch is quite simple: def get_json(self):
return self.request.get_json(silent=True) |
Another thing @cc-jj : can you check if the current |
@antonpirker I confirm the bug has been fixed on master. Thanks. |
Great! So I am closing this! |
How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.16.0
Steps to Reproduce
Werkzeug 2.1.0 changed the default behavior of
Request.get_json()
. See here:Application code:
Expected Result
There should not be any internal error in sentry_sdk.
Actual Result
There was an internal error in sentry_sdk. From the application logs:
Proposed solution
Use
request.get_json(silent=True)
which works with Werkzeug before and after 2.1.0.The text was updated successfully, but these errors were encountered: