feat(profiling): Enable profiling for ASGI frameworks #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables profiling for ASGI frameworks. When running in ASGI sync views, the transaction gets started in the main thread then the request is dispatched to a handler thread. We want to set the handler thread as the active thread id to ensure that profiles will show it on first render.
Zylphrex
force-pushed
the
txiao/feat/enable-profiling-for-asgi-frameworks
branch
from
4411f92
to
2c9d119
Compare
Zylphrex
changed the title
Zylphrex
added a commit
that referenced
this pull request
Jan 10, 2023
Following up to #1824 to set the active thread id for quart.
antonpirker
reviewed
Jan 12, 2023
antonpirker
reviewed
Jan 12, 2023
| with hub.configure_scope() as sentry_scope: | ||
| if sentry_scope.profile is not None: | ||
| sentry_scope.profile.active_thread_id = ( | ||
| threading.current_thread().ident |
There was a problem hiding this comment.
Because current_thread() can be a dummy object (see https://docs.python.org/3/library/threading.html#threading.current_thread) maybe it is saver to use threading.get_ident()?
(But if the dummy object also has a .ident my comment can be ignored)
sl0thentr0py
approved these changes
Jan 17, 2023
Zylphrex
added a commit
that referenced
this pull request
Jan 19, 2023
Following up to #1824 to set the active thread id for quart.
sl0thentr0py
pushed a commit
that referenced
this pull request
Mar 6, 2023
Following up to #1824 to set the active thread id for quart.
sl0thentr0py
pushed a commit
that referenced
this pull request
Mar 6, 2023
Following up to #1824 to set the active thread id for quart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables profiling for ASGI frameworks. When running in ASGI sync views, the
transaction gets started in the main thread then the request is dispatched to a
handler thread. We want to set the handler thread as the active thread id to
ensure that profiles will show it on first render.