ref(profiling): Remove sample buffer from profiler #1791
Merged
+283
−619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains some small tweaks to speed up the profiler. - changed from a namedtuple to a regular tuple as namedtuples were much slower but the tradeoff here is that it's more legible - moved away from `os.path.abspath` as it was doing some extra operations that were unnecessary for our use case
The sample buffer kept 30s of samples around in memory. This introduces a noticeable memory overhead on systems with less memory available. This change removes the buffer and directly writes to the profile itself where the sample is processed on the fly instead of at the end.
Zylphrex
force-pushed
the
txiao/ref/remove-sample-buffer-from-profiler
branch
from
480a127 to
a4ba6a8
Compare
Base automatically changed from
txiao/perf/performance-tweaks-to-profile-sampler
to
master
January 5, 2023 15:56
Zylphrex
commented
Jan 5, 2023
Zylphrex
commented
Jan 5, 2023
sl0thentr0py
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample buffer kept 30s of samples around in memory. This introduces a noticeable memory overhead on systems with less memory available. This change removes the buffer and directly writes to the profile itself where the sample is processed on the fly instead of at the end.