perf(profiling): Performance tweaks to profile sampler #1789
+201
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains some small tweaks to speed up the profiler. - changed from a namedtuple to a regular tuple as namedtuples were much slower but the tradeoff here is that it's more legible - moved away from `os.path.abspath` as it was doing some extra operations that were unnecessary for our use case
Zylphrex
commented
Dec 16, 2022
sentry_sdk/profiler.py
Outdated
| # Make sure to keep in mind that the stack is ordered from the inner most | ||
| # from to the outer most frame so be careful with the indexing. | ||
| stack = tuple( | ||
| prev_stack[prev_depth - (depth - i)] |
There was a problem hiding this comment.
One benefit of this is that we're reusing the raw frame tuples across samples which helps with the overall memory usage as the number of duplicate frames across subsequent stacks can be a lot.
sl0thentr0py
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains some small tweaks to speed up the profiler.
os.path.abspathas it was doing some extra operations that were unnecessary for our use case