Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link errors to OTel spans #1787

Merged
merged 10 commits into from
Dec 19, 2022

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Dec 15, 2022

This links Sentry errors to performance spans originated in OTel. Fixes #1786

Unverified

This user has not yet uploaded their public signing key.
@antonpirker antonpirker changed the title Add trace information to error events Link errors to OTel spans Dec 15, 2022

Unverified

This user has not yet uploaded their public signing key.
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM; maybe check instrumenter and use OTEL method/constant

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
…om:getsentry/sentry-python into antonpirker/1786-link-errors-to-otel-spans

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@adinauer
Copy link
Member

:shipit:

@antonpirker
Copy link
Member Author

Tests for the event_processor are still missing. But then I think we are good

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@antonpirker antonpirker merged commit 6959941 into master Dec 19, 2022
@antonpirker antonpirker deleted the antonpirker/1786-link-errors-to-otel-spans branch December 19, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link errors to OTel spans
2 participants