-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add Starlite integration #1748
Conversation
I guess this needs to be updated @gazorby |
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
Hey @Goldziher and @gazorby ! I ran the test suite and the test for Python 3.7 and 3.8 are failing. Could you have a look: https://github.com/getsentry/sentry-python/actions/runs/3866938112/jobs/6611898016 |
Should be fixed now @antonpirker! |
Thanks for the update! Now please skip the tests if the starlite package is not installed. Similar like we do in starlette tests: https://github.com/getsentry/sentry-python/blob/master/tests/integrations/starlette/__init__.py (this should fix the failing opentelemetry tests) And in the |
You can run the linters locally by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review.
First @gazorby and @Goldziher: Great work! I have now created a demo app like this: When I access the endpoint the error that ends up in Sentry as "generic Starlite request" and I am not sure why not a proper transaction name is set: Could you please check if you can get a proper name or tell me what I do wrong? |
Should be fixed now @antonpirker |
I started the tests again, and will review again tomorrow! Thanks for the quick fixes! |
All the tests are also green now! Nice work! The things missing now @gazorby is in my two comments in the review. (One is just nitpicking, so feel free to ignore) One thing I also noticed is that there is only |
One last thing @gazorby . See above! |
@antonpirker As I refactored |
please in another PR. |
I think we are good to go! Amazing work @gazorby, thanks a lot! We will try to ship a new version of the SDK this week. If you send me your shipping address to anton (dot) pirker {at} sentry .dot. io I can send you a little bit of swag as a small "thank you". |
Thanks @antonpirker! |
Thanks @gazorby! |
Starlite support has been released in version 1.13.0 of the Sentry SDK: |
Thanks for the quick release @antonpirker ! |
No problem! Do not forget to send me your shipping address and t-shirt size to anton.pirker@sentry.io |
Supplant #1597 and resolves #1549.