Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage creation for head of trace #1589

Merged
merged 6 commits into from
Sep 5, 2022
Merged

Baggage creation for head of trace #1589

merged 6 commits into from
Sep 5, 2022

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Aug 30, 2022

closes #1587, #1479

@sl0thentr0py sl0thentr0py force-pushed the neel/head-baggage branch 3 times, most recently from 3814acc to 05e03c5 Compare August 30, 2022 20:37
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicking.
Your change is easy readable like the "Kronenzeitung". I like it! (the change, not the newpaper)

@sl0thentr0py sl0thentr0py force-pushed the neel/head-baggage branch 2 times, most recently from 974a5f6 to 67a7200 Compare August 31, 2022 12:59
@sl0thentr0py
Copy link
Member Author

sl0thentr0py commented Sep 2, 2022

testing with sample app where Django renders an html template, and then the JS bundle with react runs, so python is the head SDK.

DSC on python transaction
{'trace_id': '81c052f3d99f42d781598e36a525788e', 'public_key': 'd655584d05f14c58b86e9034aab6817f', 'sample_rate': '1.0', 'release': '0.0.1', 'environment': 'dev', 'transaction': '/server_side/app/'}

meta tag injected into HTML
<meta name="sentry-trace" content="81c052f3d99f42d781598e36a525788e-b6635497ec50569a-1">
<meta name="baggage" content="sentry-trace_id=81c052f3d99f42d781598e36a525788e,sentry-environment=dev,sentry-release=0.0.1,sentry-public_key=d655584d05f14c58b86e9034aab6817f,sentry-transaction=/server_side/app/,sentry-sample_rate=1.0">


DSC on JS transaction
{"trace_id":"81c052f3d99f42d781598e36a525788e","environment":"dev","release":"0.0.1","public_key":"d655584d05f14c58b86e9034aab6817f","transaction":"/server_side/app/","sample_rate":"1.0"}

@sl0thentr0py sl0thentr0py marked this pull request as ready for review September 2, 2022 15:26
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) September 5, 2022 11:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sl0thentr0py sl0thentr0py merged commit 6db44a9 into master Sep 5, 2022
@sl0thentr0py sl0thentr0py deleted the neel/head-baggage branch September 5, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate and propagate dynamic sampling context when Python is head of trace
2 participants