Remove TRANSACTION_SOURCE_UNKNOWN and default to CUSTOM #1558
+22
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…USTOM `unknown` is only supposed to be inferred by relay as a default and not set by any SDKs. Additionally, fix some of the other cases where start_transaction was begin called without a source in integrations.
Lms24
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
LGTM! Just a question: Are we sure that whenever we set TRANSACTION_SOURCE_ROUTE, the transaction name is actually a route and not some sort of unparameterized URL? Just asking because I'm probably not up to date w/ the latest status of high-cardinality transaction names in Pythonland.
|
@sl0thentr0py perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1557
see getsentry/develop#667
unknownis only supposed to be inferred by relay as a default and notset by any SDKs.
Additionally, fix some of the other cases where
start_transactionwasbeing called without a source in integrations.