-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-enable Starlette and FastAPI #1533
Auto-enable Starlette and FastAPI #1533
Conversation
…istent routes. refs #1514
…sentry-python into antonpirker/1514-fastapi-bugs
…ub.com:getsentry/sentry-python into antonpirker/1531-auto-enable-starlette-fastapi
…ette or FastAPI was auto enabled.
making this a draft since we should wait with shipping this |
In case that the ASGIMiddleware is used when also the integrations are auto enabled I now output an error message during startup: There is also a PR to improve the linked documentation: getsentry/sentry-docs#5390 |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
…ion at the same time.
…ub.com:getsentry/sentry-python into antonpirker/1531-auto-enable-starlette-fastapi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integration is causing us issues and we'd like to turn off the starlette/fastapi sentry integration, is there a way to disable this auto-enable behaviour? |
Hey @ps-george ! First: What kind of issues are the auto-enabling starlette/fastapi integrations causing you, can you elaborate? About your question: There is a option for sentry_sdk.init() that is called You can then add some of those auto enabling integrations with the hth |
RE @ps-george , we are seeing something similar:
Seems related to #1603 and the order of imporing perhaps? Since the errir seems to come from the |
The integrations for Starlette and FastAPI should be auto enabled.
This is for easier installation of the Sentry SDK. The SDK will detect if Starlette and/or FastAPI is installed and then the integrations are enabled automatically.
Fixes #1531