Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid sending empty Baggage header #1507

Merged
merged 2 commits into from
Jul 18, 2022
Merged

fix: avoid sending empty Baggage header #1507

merged 2 commits into from
Jul 18, 2022

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Jul 18, 2022

According to W3C Working Draft spec, the Baggage header must contain at least one value; header with empty value string is invalid.

According to W3C Working Draft spec, the Baggage header must contain at least one value, an empty value is invalid.
@intgr
Copy link
Contributor Author

intgr commented Jul 18, 2022

I ran across an HTTP service that breaks when an empty Baggage header is sent by the client. It's also a waste of bandwidth, no data is being communicated.

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) July 18, 2022 20:01
@sl0thentr0py sl0thentr0py merged commit bd48df2 into getsentry:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants