-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logging levelno instead of levelname. Levelnames can be overridden #1449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR @rrauenza !
Please add tests that change the level name of all levels and test for _logging_to_event_level
returning the correct event level name here:
https://github.com/getsentry/sentry-python/blob/master/tests/integrations/logging/test_logging.py
If we have all those little changes, I think we are good to go!
Thanks!
not set ... I'm not sure how to test that, so that line is commented out. Ah, I see: https://stackoverflow.com/a/70806760/2077386 I'm not sure sentry will see this case... |
Hey @rrauenza ! Thanks for the update! |
@sl0thentr0py could you please have a look at this? |
Hey @rrauenza ! Thanks for this contribution, really great! If you send me your shipping address to anton (dot) pirker [at] sentry {dot} io I can send you a couple of stickers as a small token of appreciation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
See #1443