feat(client-reports): Record event_processor client reports #1281
+91
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
commented
Dec 16, 2021
| @@ -81,6 +81,9 @@ def init_sdk(timeout_warning=False, **extra_init_args): | |||
| transport=TestTransport, | |||
| integrations=[GcpIntegration(timeout_warning=timeout_warning)], | |||
| shutdown_timeout=10, | |||
| # excepthook -> dedupe -> event_processor client report gets added | |||
| # which we don't really care about for these tests | |||
| send_client_reports=False, | |||
There was a problem hiding this comment.
I just turned client reports off for the GCP tests since the actual problem is unrelated and caused by the same exception being caught twice and dropped by the DedupeIntegration event processor.
I added a separate test for the case below.
sl0thentr0py
requested review from
a team,
rhcarvalho and
lobsterkatie
and removed request for
a team
sl0thentr0py
changed the title
rhcarvalho
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record client reports of
event_processortype when dropped.Closes #1210
and https://getsentry.atlassian.net/browse/WEB-341