fix(tracing): Fix race condition between finish and start_child #1203
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
fix-finish-race
branch
from
74583bf to
992d14a
Compare
kamilogorek
force-pushed
the
fix-finish-race
branch
from
992d14a to
6583970
Compare
AbhiPrasad
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
__exit__method, we callself.finishfirst, and then we restore the previous span to the scope. Because of that, in some circumstances, it can happen, thatstart_childwill be called on the Transaction which_span_recorderhas been already deleted from the instance, making the call below blow up without a proper check.In our case, we performed db calls through our options cache inside the custom transport - https://github.com/getsentry/sentry/blob/14dc81c124e4ab4d86967c14e44a7bb8af8ca742/src/sentry/utils/sdk.py#L278-L280