Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda): Fix bug for initial handler path #1139

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

ahmedetefy
Copy link
Contributor

@ahmedetefy ahmedetefy commented Jul 5, 2021

This PR:-

  • Fixes bug that would technically fail if the initial handler for a lambda function by adding support for x.y.z rather than just x.y
  • Adds support for initial handler dir paths in the format of x/y.z

Ref: https://sentry.zendesk.com/agent/tickets/49603

ahmedetefy and others added 2 commits July 5, 2021 14:46
Adds support for long initial handler paths in the format of `x.y.z`
and dir paths in the format of `x/y.z`
@ahmedetefy ahmedetefy requested review from untitaker, a team, kamilogorek and lobsterkatie and removed request for a team and kamilogorek July 5, 2021 12:58
@ahmedetefy ahmedetefy force-pushed the ahmed-handle-dir-path-serverless branch 2 times, most recently from a967a32 to 9e4ab0a Compare July 5, 2021 15:04
@ahmedetefy ahmedetefy force-pushed the ahmed-handle-dir-path-serverless branch from 9e4ab0a to 25dde24 Compare July 5, 2021 15:27
@ahmedetefy ahmedetefy merged commit ab0cd2c into master Jul 5, 2021
@ahmedetefy ahmedetefy deleted the ahmed-handle-dir-path-serverless branch July 5, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants