Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integration): Add Httpx Integration #1119

Merged
merged 5 commits into from
May 31, 2021
Merged

feat(integration): Add Httpx Integration #1119

merged 5 commits into from
May 31, 2021
+159 −0

Conversation

elonzh
Copy link
Contributor

@elonzh elonzh commented May 19, 2021 •
edited
Loading

close #1084

@elonzh elonzh marked this pull request as ready for review May 19, 2021 12:23
@ahmedetefy ahmedetefy self-requested a review May 27, 2021 06:31
@ahmedetefy
Copy link
Contributor

Hey Thanks for the PR! It looks good!

Just a couple of minor points:
1- Can you add a test for outgoing trace headers?
For reference something like ->

sentry-python/tests/integrations/stdlib/test_httplib.py

Line 120 in 4b4ffc0

def test_outgoing_trace_headers(

2- Please document your code and tests

@elonzh
Copy link
Contributor Author

elonzh commented May 28, 2021

Hey Thanks for the PR! It looks good!

Just a couple of minor points:
1- Can you add a test for outgoing trace headers?
For reference something like ->

sentry-python/tests/integrations/stdlib/test_httplib.py

Line 120 in 4b4ffc0

def test_outgoing_trace_headers(

2- Please document your code and tests

check out the new commit

@elonzh elonzh force-pushed the feat/httpx-integration-support branch from 8dc7400 to 43aee0f Compare May 28, 2021 03:48
@ahmedetefy ahmedetefy changed the title feat: add httpx integration feat(integration): Add Httpx Integration May 31, 2021
@ahmedetefy
Copy link
Contributor

ahmedetefy commented May 31, 2021 •
edited
Loading

Thanks for looking into my comments!

Please add a # type: ignore comment to the httpx imports line to pass the linter tests

@elonzh
Copy link
Contributor Author

elonzh commented May 31, 2021

Thanks for looking into my comments!

Please add a # type: ignore comment to the httpx imports line to pass the linter tests

Done.

@ahmedetefy ahmedetefy merged commit e2d0893 into getsentry:master May 31, 2021
@AbhiPrasad AbhiPrasad mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedetefy ahmedetefy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integration for httpx
2 participants
@elonzh @ahmedetefy