-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support China domain in lambda cloudwatch logs url #1051
Conversation
Is that the only region where the domain is different? |
Ah good question. It looks like AWS has three partitions: aws - I don't think we should worry about the |
ok this makes sense. there are some failing testcases and lint jobs. Could you check them locally? CONTRIBUTING.md should contain enough info to get started. |
@untitaker I'm not sure why the tests are failing for python >= 3.7 for my PR, afaik my changes should not have affected this.
and
|
Thanks for the PR! |
The AWSLambdaIntegration adds the cloudwatch URL in the context but the domain is hardcoded and doesn't work for China regions.