feat(rq): Add enqueued_at and started_at to rq job extra #1024
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The started_at attribute of a job becomes None after the worker finishes, because the worker calls the cleanup method of the job, which erases some of the meta-information. So immediately after creating a job, we call save to save this information to redis and after refresh to load it. The same technique is used in the rq library itself when testing the job module.
|
Hm, the same tests fail in the master before PR changes. I guess I have to wait for the green master |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
sl0thentr0py
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #144
Add enqueued_at and started_at to extra["rq-job"] on RQ integration
The test was a bit tricky because the job was missing the started_at attribute after the worker finished. I added information about this to the commit with test.
Also another question. Are we satisfied that the time in the fields will be in the format '2021-02-16 18:55:17.220349', or do we need some special format?