fix(v8/feedback): Avoid lazy loading code for syncFeedbackIntegration
#14918
+43
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #14891 This PR updates the sync feedback integration to avoid it pulling in the `lazyLoadIntegration` code. This is not really needed and leads to some problems (and also bundle size increase). For this I updated the type signature of `buildFeedbackIntegration` to ensure that _either_ `lazyLoadIntegration` _or_ the getter functions are provided, so we can type-safely use this. We probably also want to backport this to v8 then.
size-limit report 📦
|
Lms24
approved these changes
Jan 7, 2025
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14895 for v8