ref(remix): Rework Error Handling #9725
Merged
+305
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #9695
Should also resolve: #9563
Rewrote the error reporting logic of Remix SDK to handle inconsistencies, missing stack traces and potential duplications.
There are 5 main error types that we are concerned.
loader
s andactions
And there are different points we can capture such as:
handleError
,action / loader / documentRequest
instrumentationErrorBoundary
An error is not guaranteed to end up only one of those utilities. Also the objects for the same error are not guaranteed to be the same in different places. That causes duplications.
So, with this patch, the new error handling / filtering logic for the instrumentation will be as below:
handleError
loader
/action
InstrumentationdocumentRequest
InstrumentationErrorBoundary
@sentry/react
ErrorBoundary
loader
/action
ErrorsThis PR also adds:
Sentry.wrapRemixHandleError
to be assigned ashandleError
forentry.server
(Needs docs / wizard support)