Skip to content

build: enable biome organizeImports feature #9693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Nov 28, 2023

This PR enables organizeImports feature of Biome. More information can be found from https://biomejs.dev/analyzer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@anonrig anonrig requested review from a team, mydea and Lms24 and removed request for a team November 28, 2023 20:48
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we validate this in CI before turning it on?

@anonrig
Copy link
Contributor Author

anonrig commented Nov 28, 2023

Shouldn't we validate this in CI before turning it on?

What do you mean? We already validate it? Linter runs rome check . which validates it. We also have tests.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I forgot we already merged in changes with biome check .

@anonrig anonrig merged commit 27f6ae1 into develop Nov 29, 2023
@anonrig anonrig deleted the enable-organize-imports branch November 29, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants