Skip to content

feat(feedback): Include Feedback package in browser SDK #9586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Nov 16, 2023

Sorry, something went wrong.

@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from 2c7379e to ac3ea44 Compare November 16, 2023 23:07
Copy link
Contributor

github-actions bot commented Nov 16, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.86 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.46 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.12 KB (0%)
@sentry/browser - Webpack (gzipped) 21.38 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.84 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.61 KB (+0.28% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.68 KB (+0.37% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 197.77 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.63 KB (+0.35% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.61 KB (+0.5% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.27 KB (+0.18% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.25 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 21.42 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.96 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.21 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.17 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 74.51 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.72 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 71.1 KB (added)

@billyvg billyvg requested review from mydea and a team November 17, 2023 20:27
mydea
mydea previously requested changes Nov 20, 2023
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I think the before send stuff ended up here!

@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from d18a401 to dc08cec Compare November 20, 2023 21:28
@billyvg billyvg changed the base branch from develop to ref-feedback-remove-browser-imports November 20, 2023 21:29
@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from dc08cec to d9c7c22 Compare November 20, 2023 21:32
Base automatically changed from ref-feedback-remove-browser-imports to develop November 20, 2023 22:22
@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from d9c7c22 to 9922d7d Compare November 20, 2023 22:26
@billyvg billyvg requested a review from mydea November 21, 2023 00:02
@@ -23,6 +23,7 @@
"access": "public"
},
"dependencies": {
"@sentry-internal/feedback": "7.81.0",
Copy link
Member Author

@billyvg billyvg Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mydea Hmm the next/remix tests are failing -- should I put this at the published alpha package for now?

@billyvg billyvg marked this pull request as ready for review November 21, 2023 15:01
@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from 3ace58c to bb53ece Compare November 21, 2023 15:24
@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from 1291314 to 27f0e59 Compare November 29, 2023 14:50
Add feedback to craft publish list, and export `Feedback` integration from browser SDK

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from 27f0e59 to 6daa463 Compare November 30, 2023 18:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@billyvg billyvg force-pushed the feat-feedback-export-from-browser branch from 44f9b9e to 758c1aa Compare November 30, 2023 23:42
@billyvg billyvg dismissed mydea’s stale review December 1, 2023 16:13

The PR was blocked due to stacked changes (which have been merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants