Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update size limit config #8631

Merged
merged 2 commits into from
Jul 26, 2023
Merged

build: Update size limit config #8631

merged 2 commits into from
Jul 26, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 25, 2023

This updates the size limit config a bit, to be a bit more structured.

  • Drop all non-gzipped entries. IMHO it is good enough to have the gzipped values, and it makes it a bit clearer and easier to compare. Not sure if we want to add e.g. a single non-gzipped one, but honestly I don't know when we would really care about that?
  • Reorder entries (not 100% sure TBH if the order is actually considered in the UI, though 😅 ).
  • Added webpack scenarios exporting just { init }, or { init, BrowserTracing } or { init, BrowserTracing, Replay } to have a realistic coverage of these scenarios.
  • Removed some secondary scenarios (e.g. there is just a single ES5 CDN bundle scenario left to cover this, not for all variations, ...

@mydea mydea added the Dev: CI label Jul 25, 2023
@mydea mydea self-assigned this Jul 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 0 B (removed)
@sentry/browser - ES5 CDN Bundle (minified) 0 B (removed)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 0 B (removed)
@sentry/browser - ES6 CDN Bundle (minified) 0 B (removed)
@sentry/browser - Webpack (gzipped + minified) 0 B (removed)
@sentry/browser - Webpack (minified) 0 B (removed)
@sentry/react - Webpack (gzipped + minified) 0 B (removed)
@sentry/nextjs Client - Webpack (gzipped + minified) 0 B (removed)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 0 B (removed)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 0 B (removed)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 0 B (removed)
@sentry/replay - Webpack (gzipped + minified) 0 B (removed)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 0 B (removed)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 0 B (removed)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.35 KB (added)
@sentry/browser - Webpack (gzipped) 21.95 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.76 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.24 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.33 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.79 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.9 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 60.48 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.37 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.13 KB (added)
@sentry/react - Webpack (gzipped) 21.96 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.85 KB (added)
@sentry/nextjs Client - Webpack (gzipped) 50.83 KB (added)

@mydea mydea force-pushed the fn/size-limit branch 2 times, most recently from a733ead to 77c30de Compare July 25, 2023 12:38
@AbhiPrasad
Copy link
Member

I would keep the minified value - it's a better analog to parse time and easier to track changes over time. https://blog.sentry.io/javascript-sdk-package-reduced/

We chose to track the minified CDN bundle over the gzipped + minified CDN bundle because the minified bundle is more representative of the bundle executed at runtime. The bundle size at runtime has a direct relationship with parse and execution time, so minimizing the minified bundle would minimize the time Sentry blocked the main thread. It’s much easier to track the impact individual changes had against the minified bundle size versus the total gzipped + minified bundle size.

We can just keep it for the CDN bundles though.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mydea mydea merged commit 1279e76 into develop Jul 26, 2023
@mydea mydea deleted the fn/size-limit branch July 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants