Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Don't gitignore .d.ts files #8472

Merged
merged 2 commits into from Jul 11, 2023
Merged

meta: Don't gitignore .d.ts files #8472

merged 2 commits into from Jul 11, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 7, 2023

Was looking at getsentry/sentry-capacitor#249 and getsentry/sentry-capacitor#394 and trying to fix this by adding a bunch of .d.ts files but they were gitignored.

I don't think we should blanket-ignore dts files so this pr removes it from gitignore.

@lforst lforst requested review from AbhiPrasad, Lms24 and mydea July 7, 2023 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.57 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.11 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.14 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.42 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.5 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.82 KB (0%)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I noticed this as well some time in the past, makes sense to me!

@mydea mydea enabled auto-merge (squash) July 10, 2023 07:58
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we're gitignoring ./build anyway, I think this is fine!

@mydea mydea merged commit 87bdcba into develop Jul 11, 2023
32 checks passed
@mydea mydea deleted the lforst-dont-gitignore-dts branch July 11, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants