Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Add a new option networkDetailDenyUrls to Sentry Replay #8439

Merged
merged 4 commits into from Jul 4, 2023
Merged

feat(replay): Add a new option networkDetailDenyUrls to Sentry Replay #8439

merged 4 commits into from Jul 4, 2023

Conversation

ziyad-elabid-nw
Copy link
Contributor

@ziyad-elabid-nw ziyad-elabid-nw commented Jun 30, 2023 •
edited

No description provided.

@ziyad-elabid-nw
Copy link
Contributor Author

ziyad-elabid-nw commented Jun 30, 2023 •
edited

In this PR, i added a new option networkDetailDenyUrls to Replay.

As a Sentry user it will help me a lot, when using both networkDetailDenyUrls and networkDetailAllowUrls together, we can achieve more fine-grained control over which URLs to include or exclude when capturing network details.

Related to this issue : #8435

@ziyad-elabid-nw ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch 3 times, most recently from 35b0909 to 5fa1d8b Compare July 1, 2023 09:35
@ziyad-elabid-nw ziyad-elabid-nw changed the title feat(replay): Add a new option NetworkDetailExcludeUrls feat(replay): Add a new option NetworkDetailExcludeUrls to Replay Jul 1, 2023
@ziyad-elabid-nw ziyad-elabid-nw changed the title feat(replay): Add a new option NetworkDetailExcludeUrls to Replay feat(replay): Add a new option NetworkDetailExcludeUrls to Sentry Replay Jul 1, 2023
mydea
mydea approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this seems good to me! I'll wait for @billyvg to also have a look (tomorrow), but IMHO this seems ready to go.

@mydea mydea self-assigned this Jul 3, 2023
@ziyad-elabid-nw ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch from 5fa1d8b to 963982e Compare July 3, 2023 08:26
@ziyad-elabid-nw
Copy link
Contributor Author

ziyad-elabid-nw commented Jul 3, 2023 •
edited

Thanks a lot, this seems good to me! I'll wait for @billyvg to also have a look (tomorrow), but IMHO this seems ready to go.

Thanks, i've just fixed the browser unit tests 💯

billyvg
billyvg reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mydea @ziyad-elabid-nw Should we maybe name this networkDetailDenyUrls to match the -AllowUrls?

@ziyad-elabid-nw
Copy link
Contributor Author

ziyad-elabid-nw commented Jul 3, 2023 •
edited

@mydea @ziyad-elabid-nw Should we maybe name this networkDetailDenyUrls to match the -AllowUrls?

Agreed, it makes more sense than networkDetailExcludeUrls in this case 👍 i'll do the changes

@ziyad-elabid-nw
Copy link
Contributor Author

Done 👍

@ziyad-elabid-nw ziyad-elabid-nw changed the title feat(replay): Add a new option NetworkDetailExcludeUrls to Sentry Replay feat(replay): Add a new option NetworkDetailDenyUrls to Sentry Replay Jul 3, 2023
@ziyad-elabid-nw ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch from 9f0ce30 to 03cb275 Compare July 4, 2023 07:54
@ziyad-elabid-nw ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch from 03cb275 to 3419e90 Compare July 4, 2023 08:03
@mydea mydea merged commit 9ede8a3 into getsentry:develop Jul 4, 2023
58 checks passed
@mydea mydea changed the title feat(replay): Add a new option NetworkDetailDenyUrls to Sentry Replay feat(replay): Add a new option networkDetailDenyUrls to Sentry Replay Jul 4, 2023
@hi019
Copy link

hi019 commented Jul 4, 2023

Thanks for this! Is there an ETA on when this PR will make it into a release?

@mydea
Copy link
Member

mydea commented Jul 5, 2023

We'll cut a release this week or at the latest next week probably, so shouldn't be too long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@mydea mydea mydea approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ziyad-elabid-nw @hi019 @mydea @billyvg