feat(replay): Consider window.open for slow clicks
#8308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
test actually fails because of #8310 |
mydea
force-pushed
the
fn/slow-click-window-open
branch
from
0680c3e
to
8f9b822
Compare
billyvg
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Should we test that the original window.open still works?
There was a problem hiding this comment.
I guess that makes sense! Will test this as well.
mydea
force-pushed
the
fn/slow-click-window-open
branch
2 times, most recently
from
ddd1efe
to
2924b32
Compare
When a click triggers `window.open()`, do not consider it a slow click.
mydea
force-pushed
the
fn/slow-click-window-open
branch
from
2924b32
to
6814844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a click triggers
window.open(), do not consider it a slow click.Closes #8301