Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix): Extract deferred responses correctly in root loaders. #8305

Merged
merged 2 commits into from Jun 15, 2023
Merged

fix(remix): Extract deferred responses correctly in root loaders. #8305

merged 2 commits into from Jun 15, 2023

Conversation

onurtemizkan
Copy link
Collaborator

Depends on #8304 for tests.

Resolves #6883

Extracts data from responses returned by defer, while injecting trace and baggage.

@AbhiPrasad
Copy link
Member

Think this should be good to merge?

@onurtemizkan
Copy link
Collaborator Author

I think so 👍

@onurtemizkan onurtemizkan marked this pull request as ready for review June 15, 2023 20:40
@AbhiPrasad AbhiPrasad merged commit ea45d20 into getsentry:develop Jun 15, 2023
31 checks passed
@onurtemizkan onurtemizkan deleted the remix-deferred-loaders branch June 30, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry Remix Causes Remix defer to fail in @remix-run/node@1.11.0
2 participants
@onurtemizkan @AbhiPrasad