Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Make withSentryConfig isomorphic #8166

Merged
merged 2 commits into from May 22, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented May 19, 2023

Fixes #5511

@lforst lforst requested review from AbhiPrasad and Lms24 May 19, 2023 09:44
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.04 KB (+0.07% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.68 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.59 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.15 KB (+0.12% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.2 KB (+0.16% 🔺)
@sentry/browser - Webpack (minified) 69.07 KB (+0.05% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.22 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.16 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.67 KB (+0.1% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.9 KB (+0.1% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 48.24 KB (+1.32% 🔺)
@sentry/replay - Webpack (gzipped + minified) 42.1 KB (+1.53% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 67.21 KB (+1.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.11 KB (+1.23% 🔺)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: We don't need the pass-through function in server/index.ts?

@lforst
Copy link
Member Author

lforst commented May 22, 2023

Just to confirm: We don't need the pass-through function in server/index.ts?

@Lms24 There it is exported from ./config anyhow. Server code is not bundled (and implicitly not multiplexed) so this file is gonna stay the same in any case.

@lforst lforst enabled auto-merge (squash) May 22, 2023 14:58
@lforst lforst merged commit ad3547d into develop May 22, 2023
35 checks passed
@lforst lforst deleted the lforst-isomorphic-with-sentry-config branch May 22, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: withSentryConfig is not a function
2 participants